Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

New rules for BME university main sites. - #5605

Merged
J0WI merged 3 commits into
EFForg:masterfrom
herczegzsolt:master
Jul 15, 2016
Merged

J0WI merged 3 commits into
EFForg:masterfrom
herczegzsolt:master

Conversation

@herczegzsolt

Copy link
Copy Markdown
Contributor

Rules for using Budapest University of Technology and Economics sites over https.

@herczegzsolt

Copy link
Copy Markdown
Contributor Author

This is my first rule contribution, please let me know if I need to fix anything. Thanks.

@J0WI

J0WI commented Jul 12, 2016

Copy link
Copy Markdown
Contributor

Thanks for contributing to HTTPS-Everywhere!
In our ruleset style guide we documented an easy way to find even more subdomains. Please have a look at it.

Please also be consistent in your code style. We prefer to use tabs.

@herczegzsolt

Copy link
Copy Markdown
Contributor Author

Updated the domain names. Please note that bme.hu is a large university domain, so it's nearly impossible to list all the sites, but I've done my best.
Also updated style to use tabs wherever possible.

@J0WI

J0WI commented Jul 13, 2016

Copy link
Copy Markdown
Contributor

Thanks a lot for updating the list!

Sadly a few hosts sends an incomplete certificate chain, which is problematic:
mit.bme.hu
teteny.bme.hu
www.teteny.bme.hu
uszoda.teteny.bme.hu
tir.teteny.bme.hu
ihfs.teteny.bme.hu
cs.bme.hu
www.cs.bme.hu

Please remove those targets and add a comment on the top documenting the issues on these hosts.

@herczegzsolt

herczegzsolt commented Jul 13, 2016 •

Copy link
Copy Markdown
Contributor Author

Could you please inform me how to check for an incomplete chain in the future? My browser accepted all these sites ‎by default.I'll do the update, and document all the problems (redirections, missing sites, chain errors) in the comments.

@J0WI

J0WI commented Jul 13, 2016

Copy link
Copy Markdown
Contributor

The problem is described in #2668 (comment)
I usually use curl and SSL Labs to verify.

@herczegzsolt

Copy link
Copy Markdown
Contributor Author

However I understand the problem with incomplete cert chains, I would still prefer to use these sites over https. Is there a way to still include them in the rule sets, while conforming to EFF requirements? I found no documentation on this topic, but there is an default_off="missing certificate chain" option in the rulesets.

Is it a good practice, to include two rulesets in the file, one for the fully working, domains, and another for the broken domains with default_off? Are the @J0WI Could you please give me an advice on this?

I'll also try to get in touch with the administrators of the broken sites, but it's not always possible to do that.

@J0WI

J0WI commented Jul 14, 2016

Copy link
Copy Markdown
Contributor

Is it a good practice, to include two rulesets in the file, one for the fully working, domains, and another for the broken domains with default_off? Are the @J0WI Could you please give me an advice on this?

Yes, that would be perfect. But make sure that you mention the relation between them in comments, that we are aware of in future.

@herczegzsolt

Copy link
Copy Markdown
Contributor Author

I just noticed that the test system is not capable of handling more than one ruleset in one file, so I split the rulesets to two files. Hopefully, the comments will explain the situation to anyone editing in the future.

@J0WI

J0WI commented Jul 15, 2016

Copy link
Copy Markdown
Contributor

Thank you, looks great!

@J0WI
J0WI merged commit 4fc20e5 into EFForg:master Jul 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants